Skip to content
Snippets Groups Projects

SNeedlewoods-01_part-time dev work (1 month)

1 unresolved thread

What?

For this proposal the focus of work will be on the new wallet API (context). The work is already ongoing since May 2024, there is this PR to organize functions and this branch to add comments, but most recent and most important is this WIP PR that adds functions to the API to make it "feature-complete" with wallet2.

There will not be a direct deliverable for the milestone and it's very unlikely the feature-complete API will be completely done (including reviews) before this proposal ends, but here are alternatives I would work on:

  • If current API PR gets finished:
    • Help with step 2 from this proposal: "Stop using the wallet2 object in the CLI and RPC wallets and instead use the wallet API."
    • Add unit_tests for the wallet API, or try to resurrect libwallet_api_tests (which are temporarily disabled)
  • If for any reason current API PR gets blocked:
    • Things found during the API work, mostly in CLI and RPC wallet. An incomplete list can be found here.

I give weekly updates on what I've worked on in the "Monero Tech Meeting", where I also get feedback from more experienced devs to decide which way to go.

Besides that I try to help out where I can. This is a "pilot" proposal to see how things work out. If the majority is satisfied at the end of this proposal, I see it as confirmation that I can justify putting more time and energy into Monero (and will increase my hourly rate in future proposals). Hopefully I will become a long term contributor for general development.

I aim for 15+ hours/week on average, but for precaution I won't promise more than 10 hours/week.

Who?

Hey, I'm SNeedlewoods, since early 2023 I'm lurking around in the Monero community. In November 2023 I joined the weekly "Seraphis wallet workgroup meeting" (now called "Monero Tech Meeting") in the no-wallet-left-behind matrix room and got encouraged by our friendly and very helpful devs to start coding for Seraphis. Only when the main focus in development shifted from Seraphis to FCMPs earlier this year, I started working on Monero core or more accurately on wallet related stuff.

Admittedly I don't have much to show and my expertise is not on par with other contributors, but I think considering the amount I'm asking for this proposal is fair.

Code contributions so far: Seraphis Monero

Payment

Work 10 hours/week for 1 month. 10 (hours/week) * 4.3 weeks_per_month = 43 hours total. I am setting my hourly rate at 0.05 XMR/hour regardless of fiat market price (but for those who care, that is roughly around 6,50€ or $7.50 per hour, according to the current 7-day range on coingecko: 123,43€-147,32€ or $136.38-$164.58), that makes for a total of 2.15 XMR.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @SNeedlewoods is patiently and systematically working on extending the Wallet API for quite a while now. As I mentioned in the No Wallet Left Behind matrix room once: It's something to not give up after the job turned out to be factors bigger and more complicated than originally anticipated.

  • luigi1111 mentioned in commit 7873bb02

    mentioned in commit 7873bb02

  • merged

    • Author Contributor

      Update

      Here is an estimate for hours of work put into this CCS. Work on:

      • Wallet API PR: ~42h
      • Tests: ~18h
      • Reviews: ~5h

      That sums to a total of around 65h.

      Work on PR:

      The Wallet API PR is about to move from "WIP" to "ready for review" soon.

      Work on Tests

      Started working on tests for the Wallet API. Currently there are:

      • Unit tests, for functions that do not rely on a daemon.
      • Functional tests, or more precisely this framework provided by @j-berman, for functions that do rely on a daemon.

      Reviewed:

      Plans

      Will continue to work on the wallet API and will try to solve review comments ASAP, but since I'll go take some days off in December I wont start a new CCS proposal now.

      Payout

      -----BEGIN PGP SIGNED MESSAGE-----
      Hash: SHA512
      
      Requesting payout to the following address: 88B7Koh1obgakQ5nZJiQyv3VdS7Mfbse1eay2wEkGEcE6miFkuhuSnN5co7pmHVDmQYjBui6tSbMeBGE6BFQr542Vj7qqE6
      -----BEGIN PGP SIGNATURE-----
      
      iQIzBAEBCgAdFiEE/UZYxqg4N5/vp+a3UQPK0XU7zHoFAmc7ZJsACgkQUQPK0XU7
      zHqymBAAta0YQsLpYKidQ7eNRYqdreK5TdJp+ompaaYDsJmXazbHQCpfe31AYzAt
      QpA8rApasIdCTuDK6x6/nJb9V95hAOZt8BIehfHaO7vbB8uWe6rb+Sm+okgNOcoo
      8UO4XvumDunHO/K+Ew36E5kZm7EEyM2DSMtT7Zuw4p+QI9cce1Qjq7d49XxOg8St
      BFVM2akLkHXTM+7IJBpQmaMFtawOAMEIyzZPNg27Vuw4aCCrFYP8rQ2Fdo7PwP2H
      Ghp54sPR1ejwytYkcjXUMOcIoP+slDJ5RvtwkyWnxfLivk1mx7Cirfoh9ifFLRC+
      lIg1qzBiFNvlTCQly8Qt2Uns1TN8jyMH+Im0CFQ2cGTmVdMTrg9u4PosXzjlYD0O
      6j6SCux/9CEAXd+BKUgdzxcIandBmE0iCmat8Y8Hf6r9cckQwM7DQFU4ytjduroz
      4UkQwkLWK4cmcLFCykJCy2Q4+TDygs3kHzF8KSk5TIBmbplMkJMvy5PdBruxwt23
      EPccPtbUjOZox39wyRQcXjIidoHCCLlIO0xwjqUNddXvPZ/krjXoLuAMgVcOOdZ/
      VhKj+D+mlo59CZrVv7/X5dtonNPR+q5pL82yVJpevQbaOa67Ly9q2K5OjHvb6HdI
      UlOcdy9y2vdR967IfVlHYziKbHBHvUcA9YHd+04+veFEuXumSlg=
      =wvs0
      -----END PGP SIGNATURE-----

      P.S.

      Thanks for all the support from CCS coordinators, upvoters, donors and dev colleagues. It's an honor to be able to work with you.

      Edited by SNeedlewoods
    • Jugding from the many commits of the PR in question here and the code changes amassed here, plus from thinking back at discussions, the amount of work declared in this payout request looks plausible to me.

      And the work is indeed near some sort of milestone, "ready for review".

    • Please register or sign in to reply
Please register or sign in to reply
Loading