Port Electron GUI to Monero

What

Port the Electron GUI from Ryo to Monero. Rebrand, make sure all core functionality works, and package it for distribution. This will be a port of the open source version of the wallet. Once the restrictive license wears out, I'll make another proposal to merge the solo pool.

Who

I'm mosu-forge, part of the Ryo-team, and at least decently liked in the Monero crowd. I'm responsible for most of the development within Ryo over the last year. I built the GUI wallet, the web wallet, the updated version of the Wordpress plugin, and more.

Why

Many Monero members have asked me to come work for Monero, and that I should port the GUI. This proposal will gauge interest from the community.

My contributions/experience:

• https://github.com/ryo-currency/ryo-wallet
• https://github.com/ryo-currency/ryo-payments-woocommerce-gateway
• ... and a whole lot more

150 XMR to port the existing Electron GUI wallet to Monero? Am I missing something?

Hi selsta

There is more work then it seems to port the wallet over, and it would be a good addition to the Monero ecosystem. Lots of users have asked for it, but nobody has yet ported it. I also need to keep it updated with new daemon releases.

This is coming from the actively hostile Ryo community. I like what @mosuforge has created but given our history and some complaints on the quality of the code, I'd give it a firm NACK.

Many Monero members have asked me to come work for Monero

Could you elaborate on the above statement?

Hi dsc

I'm posting this as a free agent, not as part of any other development team. How can I elaborate more? I mean that Monero community members have asked me to leave Ryo and join Monero. I am testing that hypothesis to see if I can get funded.

Besides our discussion on Discord today, we have never interacted, have we? Can you elaborate yourself on complaints about the code quality?

This specific proposal gets a NACK from my side for the following reason:

ryo-wallet isn’t open source. It is source available with “(c) Ryo Currency Project”. If we fork ryo-wallet-libre and there’s a bug fix in ryo-wallet, we aren’t allowed to apply the same bug fix. We depend on the permission of Ryo Currency Project for every single upstream change. Considering the projects hostility against Monero, this a bad idea.

I also think that 150 XMR ($15000) is a bit too much for the work proposed.

I like what @mosuforge has created

Agree with dsc_ here.

Monero community members have asked me to leave Ryo and join Monero.

Uhhh, okay? Well, don't get me wrong. I applaud any wallet development in 'the space' and you made something you can be proud of. However, given your strong Ryo background, I would never run this port because I question your motives (open-source or not).

That is my personal opinion.

Selsta has some complaints regarding the current license, perhaps you can expand on that.

Besides our discussion on Discord today, we have never interacted, have we?

?

Can you elaborate yourself on complaints about the code quality?

I was glancing over the code and seeing some loose value comparisons. You should probably avoid type juggling in Javascript. Just nitpicking. Not the end of the world but gives me a bad signal.

In addition, Electron+vue is not my thing. Again, personal opinion.

Goodluck on the proposal. Very strong NO from me due to Ryo affiliation.

About licensing I could fork the Loki GUI that forked the Ryo GUI. They added some features and also do not have a restrictive license. My intention is not to add any sort of malware, since that is pretty illegal and I am at least a man with standards.

The Ryo affiliation doesn't strike me as harshly as it may some others. As far as I have seen, Mosu Forge hasn't had the same kind of abrasive attitudes towards Monero as the other members of the community, so I have no problems with him. Though I also can see how the bad blood can taint anyone trying to do work for both projects. Given my mentioned stance, I will attempt to look at the proposal from a neutral standpoint.

Others have mentioned the price. Do you think you can give a breakdown of expected hours and what work is expected to happen to make this a thing? Forking the Loki GUI would indeed solve some of the issues @selsta presented (and those issues are actually quite large).

If the price can be justified, and the licensing work is fine, I see no reason to not merge and fund this proposal. This is speaking the viewpoint of a person who is greatly appreciative of the work you did on the Woocommerce plugin (i.e. making it actually usable).

Real mosu forge here.

I would be more than happy to see Monero users have another wallet choice. However, the above proposal was not created by me. It would not be fair to the Ryo investors for me to make such a proposal. Signed message below, public key can be found in the ryo-currency repo.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

In response to the following link, I did not make this request.
https://repo.getmonero.org/monero-project/ccs-proposals/merge_requests/85
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEx8qIjI7MgV9v9hnkg6LJxzvxIGMFAl0npcsACgkQg6LJxzvx
IGNjRAgAuCfqfjSZAtY2n+QvKZIYkYpAt5wDS4NaUaXLp+10Eq8gpY6m2I+15Vxn
TIOnN3PHgiMyEiCuMYsEyiF4wjisocZchBbUJbo5fZWFJlHeEXs4/mxuHlnZ7j84
YKJzPA8e8zW8yVZ8uRQTYyIVk4cFSDLJuvqmnZaYi/WSSr7c6qwGemsSjavPimxY
eGiN30pB/CsCqR9Ut+BeWnh+kNZSmsH6JnOHCyx3Pi+0GZJYOcsyKJygWU0LQBVN
+AqO6wcEmV89AtRDOKSpMYrwKQzkmyPUjCIIGebNJ4noFyB17YxHdWCuZZMWrONc
55sYyNI9OAC+a8wBdb17bXLEcmrqpQ==
=X/8F
-----END PGP SIGNATURE-----

This merge request will be closed, as it seems this is a fraudulent proposal.

@mosuforge are you also able to make a PGP signed message verifying your identity? If not, would you like to give an explanation for why you did this?

closed